Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore][WIP] Adds assertions to rollback error path test #944

Closed
wants to merge 1 commit into from
Closed

[Chore][WIP] Adds assertions to rollback error path test #944

wants to merge 1 commit into from

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Jul 27, 2023 •
edited
Loading

Description

This PR captures the update to the rollback error path, with regard to the create and release lifecycle for a RWContext in a pocket node.

Issue

Related to #861

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • adds a test for the error path of the treeStore when a rollback fails

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added the large Pull request is large label Jul 27, 2023
@dylanlott dylanlott mentioned this pull request Jul 27, 2023
Merged
20 tasks
@dylanlott dylanlott changed the base branch from main to persistence/savepoints-initial July 27, 2023 19:52
@dylanlott dylanlott requested a review from Olshansk July 27, 2023 19:53
@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Jul 27, 2023
@dylanlott dylanlott self-assigned this Jul 27, 2023
@dylanlott dylanlott force-pushed the persistence/rollback-error-path branch from b6c8068 to 8faf2b2 Compare July 28, 2023 00:08
Base automatically changed from persistence/savepoints-initial to main July 31, 2023 16:04
@reviewpad reviewpad bot added large Pull request is large small Pull request is small and removed small Pull request is small large Pull request is large labels Jul 31, 2023
@dylanlott dylanlott changed the title [Chore][Persistence] Adds assertions to rollback error path test [Chore][WIP] Adds assertions to rollback error path test Jul 31, 2023
@dylanlott dylanlott force-pushed the persistence/rollback-error-path branch from 935296e to 6d075c5 Compare July 31, 2023 18:38
Olshansk
Olshansk requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor NITS, but why is it a draft?

persistence/trees/trees_test.go
tmpdir := t.TempDir()
cfg := newTestDefaultConfig(t, dbUrl)
cfg.Persistence.TreesStoreDir = tmpdir
pmod := newTestPersistenceModule(t, cfg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pmod := newTestPersistenceModule(t, cfg)
pMod := newTestPersistenceModule(t, cfg)

@dylanlott dylanlott closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk requested changes

Assignees

@dylanlott dylanlott

Labels
small Pull request is small
Projects
V1 Dashboard
Status: Done
Milestone
M1: Pocket PoS (Proof of Stake)
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @Olshansk